[fix][test] Fix flaky NegativeAcksTest.testNegativeAcksWithBackoff #24342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
May 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24342 +/- ##
============================================
- Coverage 73.57% 72.74% -0.84%
+ Complexity 32624 32191 -433
============================================
Files 1877 1869 -8
Lines 139502 158700 +19198
Branches 15299 19957 +4658
============================================
+ Hits 102638 115443 +12805
- Misses 28908 33984 +5076
- Partials 7956 9273 +1317
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
added
release/3.0.14
release/4.0.7
and removed
release/3.0.13
release/4.0.6
labels
lhotari
added
release/3.0.15
release/4.0.8
and removed
release/3.0.14
release/4.0.7
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This test sometimes blocks at
consumer.receive()at line 261. The problem is introduced in this PR #23986. For batch sending scenarios, the current way of creating producers cannot guarantee that all messages are sent out in one batch. Therefore, for batch messages, executingconsumer。negativeAcknowledgeonly once is not enough.Modifications
By adding
batchingMaxPublishDelaywhen creating the producer, all messages are guaranteed to be sent together.Documentation
docdoc-requireddoc-not-neededdoc-complete